feat: refactor sync requests to use driveServerClient#267
Merged
Conversation
…eck for rate limiting
AlexisMora
reviewed
Mar 9, 2026
Comment on lines
+332
to
+339
| const { data, error } = await driveServerClient.GET('/files', { | ||
| query: { | ||
| limit: this.config.fetchFilesLimitPerRequest, | ||
| offset: 0, | ||
| status: 'ALL', | ||
| updatedAt: updatedAtCheckpoint?.toISOString(), | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Make this a reusable function inside src/infra/drive-server/files/services where we store the rest of the file related api calls.
This way its reusable. we can test it in isolation and we also hide complexity to where its needed.
Comment on lines
+370
to
+377
| const { data, error } = await driveServerClient.GET('/folders', { | ||
| query: { | ||
| limit: this.config.fetchFilesLimitPerRequest, | ||
| offset: 0, | ||
| status: 'ALL', | ||
| updatedAt: updatedAtCheckpoint?.toISOString(), | ||
| }, | ||
| }); |
|
AlexisMora
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
Why